Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for multiple Reply-Tos #1169

Merged
merged 5 commits into from
Mar 25, 2022
Merged

feat: Add support for multiple Reply-Tos #1169

merged 5 commits into from
Mar 25, 2022

Conversation

RyanFlemingOlo
Copy link
Contributor

@RyanFlemingOlo RyanFlemingOlo commented Mar 15, 2022 •
edited

Fixes

Closes #339

Add support to add multiple reply to email addresses.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@RyanFlemingOlo RyanFlemingOlo marked this pull request as ready for review March 16, 2022 13:24
beebzz
beebzz reviewed Mar 22, 2022
View reviewed changes
Copy link

@beebzz beebzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @RyanFlemingOlo! Feel free to fix the failing test then we can take another look.

@RyanFlemingOlo
Copy link
Contributor Author

@beebzz I believe I have the test fixed and it is passing locally.

childish-sambino
childish-sambino approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice work 🏅

@childish-sambino childish-sambino merged commit 9385d27 into sendgrid:main Mar 25, 2022
@RyanFlemingOlo RyanFlemingOlo deleted the add-reply-tos-support branch March 25, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beebzz beebzz beebzz left review comments

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SendGrid api3 has no way to add multiple ReplyTo Emails
3 participants
@RyanFlemingOlo @beebzz @childish-sambino