Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bounce usage Fixes #370 #529

Merged
merged 6 commits into from
Oct 4, 2017

Conversation

Gimly
Copy link
Contributor

@Gimly Gimly commented Sep 30, 2017

Fixed all the Usage.md examples that were using start_time and end_time to use the same examples as in the SendGrid documentation and use unix time for those queries.

Used unix timestamp for the start_time and end_time in the bounce example.

Fixes sendgrid#370
Used the same example query parameters to the list invalid emails examples than on SendGrid's documentation.
Used the same example query parameters to the list invalid blocks examples than on SendGrid's documentation.
Used the same example query parameters to the list spam reports examples than on SendGrid's documentation.
Used the same example query parameters to the list unsubscribes examples than on SendGrid's documentation.
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap labels Sep 30, 2017
@thinkingserious thinkingserious merged commit 948bc8a into sendgrid:master Oct 4, 2017
@thinkingserious
Copy link
Contributor

Hello @Gimly,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@Gimly
Copy link
Contributor Author

Gimly commented Oct 4, 2017

Hey, you're welcome, it was a funny way to discover your API and helping at the same time. Thanks for the swag!

@Gimly Gimly deleted the 370-UpdateBounceUsage branch October 4, 2017 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants