Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for duplicate keys in QueryParams #586

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Allow for duplicate keys in QueryParams #586

merged 1 commit into from
Aug 21, 2018

Conversation

Knugel
Copy link
Contributor

@Knugel Knugel commented Oct 22, 2017

Fixes #365.
This PR changes the way QueryParams are parsed from JSON.
As JSON requires unique keys only the last value is returned in case of duplicates.
By using a JsonTextReader instead of JsonConvert#DeserializeObject this behaviour can be changed.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 22, 2017
@thinkingserious
Copy link
Contributor

This is awesome @ImbaKnugel!

Do you mind adding a test or two :)

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 28, 2017
@Knugel
Copy link
Contributor Author

Knugel commented Oct 29, 2017

I'm not sure how to properly test the methods without changing their visibility.

@mbernier
Copy link
Contributor

mbernier commented Nov 3, 2017

@ImbaKnugel

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@thinkingserious thinkingserious added the type: bug bug in the library label Mar 5, 2018
@thinkingserious thinkingserious merged commit b523445 into sendgrid:master Aug 21, 2018
@thinkingserious
Copy link
Contributor

Hello @ImbaKnugel,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants