Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test to check the license date #610

Merged
merged 2 commits into from
Aug 21, 2018

Conversation

VitorBarbosa
Copy link
Contributor

@VitorBarbosa VitorBarbosa commented Oct 28, 2017

Fixes #606

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added a unit test to check if the LICENSE.txt file contains the current year for the copyright.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@mbernier
Copy link
Contributor

Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assigning this to @thinkingserious

@VitorBarbosa
Copy link
Contributor Author

@thinkingserious @mbernier I only see test names from failed builds, when all tests pass it only shows up as

Total tests: 325. Passed: 325. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 54.5378 Seconds

@mbernier
Copy link
Contributor

mbernier commented Nov 3, 2017

@VitorBarbosa

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@thinkingserious thinkingserious added the type: twilio enhancement feature request on Twilio's roadmap label Mar 5, 2018
@thinkingserious thinkingserious merged commit a24956b into sendgrid:master Aug 21, 2018
@thinkingserious
Copy link
Contributor

Hello @VitorBarbosa,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range
4 participants