Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed virtual bug #702

Merged

Conversation

psboies
Copy link
Contributor

@psboies psboies commented Jun 19, 2018

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 19, 2018
@SendGridDX
Copy link

SendGridDX commented Jun 19, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

This is awesome @psboies! This is on our backlog for a merge.

@psboies
Copy link
Contributor Author

psboies commented Jun 26, 2018

Thanks @thinkingserious . Have a great day!

@jpurpura jpurpura added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Aug 13, 2018
@thinkingserious thinkingserious merged commit 6a573dd into sendgrid:master Aug 21, 2018
@thinkingserious
Copy link
Contributor

Hello @psboies,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@psboies
Copy link
Contributor Author

psboies commented Aug 22, 2018

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants