Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly link online version of CLA and fix email mentions #767

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

bharatr21
Copy link
Contributor

@bharatr21 bharatr21 commented Oct 8, 2018

Update README.md to directly link the online version of the CLA and fix the email mentions

Fixes #771

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Directly link to the online version of the CLA (Contributor License Agreement)
  • Fix email mentions similar to sendgrid-python and sendgrid-java repositories.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

Update README.md to directly link the online version of the CLA and fix the email mentions
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 8, 2018
@devchas devchas added the status: work in progress Twilio or the community is in the process of implementing label Oct 17, 2018
@thinkingserious thinkingserious added hacktoberfest difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code and removed status: code review request requesting a community code review or review from Twilio labels Oct 22, 2018
@thinkingserious thinkingserious merged commit 3a86105 into sendgrid:master Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @Bharat123rox,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @Bharat123rox,

Thanks again for the PR!

You have earned 6 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The link in About section of README.md redirects to an email and not an actual list of developers
3 participants