Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

750 contactdb helpers #770

Closed
wants to merge 8 commits into from
Closed

Conversation

Gimly
Copy link
Contributor

@Gimly Gimly commented Oct 8, 2018

Fixes #750

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Adds a helper class and interface that allows to simplify the use of the Contacts DB API

Creates the new folder that contains the contact db helper,
new namespace and new contact helper class.

Start working on issue #750
To simplify querying the contacts API, I created an interface.
It contains all the methods that are available on the contacts API.

The instance for this interface is retrieved by a  method on the ISendGridClient.
* Adds a ContactDbClient class that implements IContactDbClient
* Continues adding methods to IContactDbClient
FInalized adding all methods to the IContactDbClient interface
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 8, 2018
@devchas devchas added hacktoberfest difficulty: hard fix is hard in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 11, 2018
@rodion-m
Copy link

Hi @Gimly ! It's really useful feature please keep going.

@Gimly
Copy link
Contributor Author

Gimly commented Jun 6, 2019

@rody66 I had forgotten about this PR, I was waiting for some feedback on what was done already. I'll try to to get back to it and see what needs to be done to finish it

@rodion-m
Copy link

rodion-m commented Jun 6, 2019 via email

@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:28
@thinkingserious
Copy link
Contributor

Since there has been no activity on this issue since March 1, 2020, we are closing this issue. If you are still interested in moving this PR forward, please feel free to reopen. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
5 participants