-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dockerized event webhook consumer example #812
feat: Add dockerized event webhook consumer example #812
Conversation
Hello @KoditkarVedant, |
Hello @KoditkarVedant, |
Hi there, I would just like to say the idea of a containerized EventKit is awesome! Is there a reason why this was never merged in the end? Is there another/better alternative? |
@os1r1s110 We're (slowly) working through the backlog of open issues/PRs. This one is near the top of that list (note that tests must be passing to be considered at this point). |
@childish-sambino Let me know if there is anything that needs to be done to get this PR merged |
examples/sendgrid-event-webhook-consumer/Src/EventWebhook/Models/UnsubscribeEvent1.cs
Outdated
Show resolved
Hide resolved
examples/sendgrid-event-webhook-consumer/Src/EventWebhook/Views/EventWebhook/Index.cshtml
Outdated
Show resolved
Hide resolved
examples/sendgrid-event-webhook-consumer/Tests/EventWebhook.Tests/EventTests.cs
Outdated
Show resolved
Hide resolved
…erized-event-webhook-consumer
…s://github.com/KoditkarVedant/sendgrid-csharp into 765-create-a-dockerized-event-webhook-consumer
examples/eventwebhook/consumer/Src/EventWebhook/Views/EventWebhook/Index.cshtml
Show resolved
Hide resolved
75b9680
to
2c56645
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Nice work! 🏅
dumb question here, but is this actually doing anything? I read the code quickly, and there doesn't seem to be any persistence layer in the app to save the events somewhere, did I miss something? |
It has no business logic and is just an example of how to parse and respond to the incoming webhooks. Add business logic here: |
Yeah ok that's what I had figured by reading the code. Seems legit, I just thought it would be similar to the old "webhook parser" project hosted on Heroku (based on Rails if my memory's good) which included a persistence layer (Postgres) and a UI to vizualize the events saved. (in the end I found the project I'm talking about and it can be found here). That project was awesome, except for the fact that now that rails dependencies were updated on Heroku, the app cannot be deployed anymore, which is sad as this was a great tool to be able to save events over the 3 days limit from Sendgrid. Nevertheless, that's a great starting point so that's still a really great addition to the repo :) Good job and have a great day! |
Fixes #765 and #572
Checklist
SendGrid has an Event Webhook which posts events related to your email activity to a URL of your choice. We need to have an easily deployable solution that allows for customers to easily get up and running processing (parse and save) their event webhooks.