Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dockerized event webhook consumer example #812

Conversation

KoditkarVedant
Copy link
Contributor

@KoditkarVedant KoditkarVedant commented Oct 28, 2018

Fixes #765 and #572

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

SendGrid has an Event Webhook which posts events related to your email activity to a URL of your choice. We need to have an easily deployable solution that allows for customers to easily get up and running processing (parse and save) their event webhooks.

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: very hard fix is very hard in difficulty type: twilio enhancement feature request on Twilio's roadmap and removed type: community enhancement feature request not on Twilio's roadmap labels Oct 28, 2018
@thinkingserious
Copy link
Contributor

Hello @KoditkarVedant,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @KoditkarVedant,

Thanks again for the PR!

You have earned 30 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@lvmajor
Copy link

lvmajor commented Jul 15, 2020

Hi there, I would just like to say the idea of a containerized EventKit is awesome!

Is there a reason why this was never merged in the end? Is there another/better alternative?

@childish-sambino
Copy link
Contributor

@os1r1s110 We're (slowly) working through the backlog of open issues/PRs. This one is near the top of that list (note that tests must be passing to be considered at this point).

@KoditkarVedant
Copy link
Contributor Author

@childish-sambino Let me know if there is anything that needs to be done to get this PR merged

@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:28
@KoditkarVedant KoditkarVedant force-pushed the 765-create-a-dockerized-event-webhook-consumer branch from 75b9680 to 2c56645 Compare August 1, 2020 11:31
@childish-sambino childish-sambino changed the title Add dockerized event webhook consumer example feat: Add dockerized event webhook consumer example Aug 3, 2020
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Nice work! 🏅

@childish-sambino childish-sambino merged commit 11fbf1e into sendgrid:main Aug 3, 2020
@lvmajor
Copy link

lvmajor commented Aug 3, 2020

dumb question here, but is this actually doing anything? I read the code quickly, and there doesn't seem to be any persistence layer in the app to save the events somewhere, did I miss something?

@childish-sambino
Copy link
Contributor

It has no business logic and is just an example of how to parse and respond to the incoming webhooks. Add business logic here:

@lvmajor
Copy link

lvmajor commented Aug 3, 2020

Yeah ok that's what I had figured by reading the code. Seems legit, I just thought it would be similar to the old "webhook parser" project hosted on Heroku (based on Rails if my memory's good) which included a persistence layer (Postgres) and a UI to vizualize the events saved. (in the end I found the project I'm talking about and it can be found here). That project was awesome, except for the fact that now that rails dependencies were updated on Heroku, the app cannot be deployed anymore, which is sad as this was a great tool to be able to save events over the 3 days limit from Sendgrid.

Nevertheless, that's a great starting point so that's still a really great addition to the repo :)

Good job and have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: very hard fix is very hard in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Dockerized event webhook consumer
4 participants