Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove references to "Whitelabel" #824

Merged
merged 7 commits into from
Jul 1, 2020

Conversation

crweiner
Copy link
Contributor

@crweiner crweiner commented Oct 31, 2018

Fixes #823

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Per the SendGrid Docs here as well as an upcoming addition to the Docs in a PR I have submitted here, the term "Whitelabel" is no longer being used in SendGrid documentation and has been "deprecated" (see here), even though the API still references it.

This PR alters the references to whitelabeling and replaces them with the following:
Whitelabel = Sender Authentication
Domain Whitelabel = Domain Authentication
IP Whitelabel = Reverse DNS
Link Whitelabel = Link branding

Signed-off-by: chandler <chandler@chandlerweiner.com>
Signed-off-by: chandler <chandler@chandlerweiner.com>
Signed-off-by: chandler <chandler@chandlerweiner.com>
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 31, 2018

CLA assistant check
All committers have signed the CLA.

Signed-off-by: chandler <chandler@chandlerweiner.com>
crweiner and others added 3 commits November 3, 2018 20:12
Signed-off-by: chandler <chandler@chandlerweiner.com>
Signed-off-by: chandler <chandler@chandlerweiner.com>
@childish-sambino childish-sambino changed the title Remove references to "Whitelabel" docs: Remove references to "Whitelabel" Jul 1, 2020
@childish-sambino childish-sambino merged commit dc44d1d into sendgrid:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove legacy "Whitelabel" Terms
4 participants