Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sendAt timestamp as 32bit integer #916

Merged
merged 2 commits into from
Jun 23, 2020
Merged

fix: sendAt timestamp as 32bit integer #916

merged 2 commits into from
Jun 23, 2020

Conversation

matrix0123456789
Copy link
Contributor

@matrix0123456789 matrix0123456789 commented Aug 7, 2019 •
edited

32bit signed integer will overflow in year 2038

Fixes

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Twilio Sendgrid, or file a Github Issue in this repository.

@matrix0123456789
Bugfix: timestamp as 32bit integer
e5a9f4a 
32bit signed integer will overflow in year 2038
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 7, 2019
aevitas
aevitas approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@aevitas aevitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

childish-sambino
childish-sambino approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matrix0123456789 Change looks good to me. Could you tick the license acknowledgment in the PR summary so I can merge this?

@childish-sambino childish-sambino changed the title Bugfix: timestamp as 32bit integer fix: sendAt timestamp as 32bit integer Jun 23, 2020
@matrix0123456789
Copy link
Contributor Author

Ok, ticked

@childish-sambino childish-sambino merged commit febd43e into sendgrid:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aevitas aevitas aevitas approved these changes

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matrix0123456789 @aevitas @childish-sambino @thinkingserious