Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ignore duplicate email addresses when serializing the message #991

Merged
merged 1 commit into from
Apr 13, 2020
Merged

feat: ignore duplicate email addresses when serializing the message #991

merged 1 commit into from
Apr 13, 2020

Conversation

childish-sambino
Copy link
Contributor

Fixes #691
Closes #939
Closes #739

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Apr 13, 2020
This was referenced Apr 13, 2020
Closed
Closed
Closed
aevitas
aevitas approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@aevitas aevitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Interesting approach, wouldn't directly have considered using a JsonSerializer to deduplicate them, but I suppose it's the best way to do it without adding too much code.

@childish-sambino
Copy link
Contributor Author

Yeah, first thought was to switch the emails to be stored in a hash set, but would cause some breakages depending on use. This is probably the least breaking, simplest approach.

@childish-sambino childish-sambino merged commit 7d0d3aa into master Apr 13, 2020
@childish-sambino childish-sambino deleted the duplicate-emails branch April 13, 2020 17:28
@childish-sambino childish-sambino mentioned this pull request Jul 6, 2020
Closed
@clinejj clinejj mentioned this pull request Jan 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aevitas aevitas aevitas approved these changes

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No email is sent when recipient email is duplicated
4 participants
@childish-sambino @aevitas @eshanholtz @thinkingserious