Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing golint and gofmt errors #148

Merged
merged 2 commits into from Oct 24, 2017

Conversation

prateekpandey14
Copy link
Contributor

This PR will fix golint and gofmt issues with all *.go files.
fixes #64
Use: golint and gofmt tool to fix the issue

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 9, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 9, 2017

CLA assistant check
All committers have signed the CLA.

@leandro-lugaresi
Copy link
Contributor

There is already an open PR (#121) to solve this issue

@thinkingserious thinkingserious added the status: duplicate duplicate issue label Oct 9, 2017
@thinkingserious
Copy link
Contributor

Hi @prateekpandey14,

Thanks for the PR! As @leandro-lugaresi mentioned, this issue is address in PR #121.

I hope you will find another issue to take on for Hacktoberfest :)

With Best Regards,

Elmer

@prateekpandey14
Copy link
Contributor Author

prateekpandey14 commented Oct 10, 2017

@leandro-lugaresi @thinkingserious
Other PR doesn't fix the golint issues with go files in examples and helpers directory.
they are only fixing gofmterrors.
can please verify the changes.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest and removed status: duplicate duplicate issue labels Oct 12, 2017
@mbernier
Copy link
Contributor

@prateekpandey14, I have merged in the PRs that came previously. Can you please look into the merge conflicts and see if you have identified anything that hasn't already been covered? We would love to give you credit for the work you did here!

@mbernier
Copy link
Contributor

Alrighty, I got everything merged - hopefully it builds with no issues!

@mbernier mbernier merged commit 3f7126b into sendgrid:master Oct 24, 2017
@thinkingserious
Copy link
Contributor

Hello @prateekpandey14,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@prateekpandey14
Copy link
Contributor Author

Thanks @thinkingserious @mbernier .
I have filled the details in above mentioned links.

@prateekpandey14 prateekpandey14 deleted the fix-lint-fmt branch October 4, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
5 participants