Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add whitelabeling helpers #306

Closed
wants to merge 11 commits into from
Closed

[WIP] Add whitelabeling helpers #306

wants to merge 11 commits into from

Conversation

bigblind
Copy link

Fixes #174

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Add helpers for whitelabeling domains.

This is a work in progress, but I'm already submitting a PR to get some early feedback. Is this what you had in mind to solve the issue?

The issue also mentioned an option to email the DNS records that need to be created, so I'm planning to just add a function called SendDNSRecords that takes an email address to send from, an address to send to, and a slice of DNSRecords.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 13, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 13, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@devchas devchas added difficulty: hard fix is hard in difficulty hacktoberfest status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap labels Oct 17, 2018
@thinkingserious thinkingserious added status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @bigblind,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @bigblind,

Thanks again for the PR!

You have earned 7 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:32
thinkingserious
thinkingserious reviewed Nov 18, 2020
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, we appreciate it!

helpers/whitelabel/branded_links.go
@@ -0,0 +1,141 @@
package whitelabel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have updated the verbiage used to describe a "whitelabel". Please update accordingly. See this PR for an example.

sendgrid.go
return &Client{request}
}

// DefaultClient is used if no custom HTTP client is defined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should be able to remove the following functions, as they now reside here: https://github.com/sendgrid/sendgrid-go/blob/main/base_interface.go

sendgrid.go
@@ -48,6 +48,82 @@ func NewSendClient(key string) *Client {
return &Client{request}
}

// NewClientForEndpoint returns a client that can send requests to a specific endpoint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this function, why not just use the default client?

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap and removed difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio labels Nov 18, 2020
@thinkingserious
Copy link
Contributor

Hello @bigblind,

Would you like to continue working on this PR? If not, please let us know and we will add it to our backlog.

With best regards,

Elmer

@thinkingserious
Copy link
Contributor

Closing until PR feedback is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious left review comments

Assignees
No one assigned
Labels
status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
5 participants
@bigblind @SendGridDX @thinkingserious @devchas @childish-sambino