Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Mail Helper Refactor #221

Closed
thinkingserious opened this issue Oct 1, 2017 · 6 comments
Closed

Java Mail Helper Refactor #221

thinkingserious opened this issue Oct 1, 2017 · 6 comments
Labels
difficulty: very hard fix is very hard in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap type: getting started question while getting started

Comments

@thinkingserious
Copy link
Contributor

Issue Summary

An interface to easily interact with the mail/send endpoint of the SendGrid v3 Web API.

The specification for this project is here and the discussion around this specification can be found here.

Acceptance Criteria

All of the use cases defined here are implemented and all corresponding tests are passing.

@Ronpgo
Copy link

Ronpgo commented Oct 1, 2017

Will this also deal 429s, i.e. sleeping the amount suggested in the response header if a rate limit exceeded?

@thinkingserious
Copy link
Contributor Author

@Ronpgo,

No, to follow that feature, please see this issue. Thanks!

With Best Regards,

Elmer

@andy-trimble
Copy link
Contributor

andy-trimble commented Oct 11, 2017

Issues #184 and #212 are due to logic in the java-http-client library. This is done explicitly via this code.

In order to maintain backwards compatability, I will deprecate the existing method, and create a new method that does not throw the IOException.

PR's for both java-http-client and sendgrid-java coming shortly.

@Ronpgo
Copy link

Ronpgo commented Oct 11, 2017 via email

@thinkingserious
Copy link
Contributor Author

thinkingserious commented Apr 6, 2018

Add #258, #176 and #213 to this release.

@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing and removed status: help wanted requesting help from the community labels May 10, 2019
@thinkingserious
Copy link
Contributor Author

Since there has been no activity on this issue since March 1, 2020, we are closing this issue. Please feel free to reopen or create a new issue if you still require assistance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: very hard fix is very hard in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap type: getting started question while getting started
Projects
None yet
Development

No branches or pull requests

5 participants