docs: Save attachment to Dropbox #304
Conversation
thinkingserious
added
the
status: code review request
|
|
|
@thinkingserious @mbernier Can you review this PR? |
|
@thinkingserious @mbernier have fixed gradle issue. Please review my code now. |
|
Hi @deepapanwar, Thank you for the PR! We want to avoid adding any non-essential dependencies to this core library, so I suggest we move your code to an example here. To complete this PR, you would create a new entry in the Table of Contents there and then describe how someone could add this code to their project. If it's easier, you might want to make another PR for that. In any case, you have earned your Hacktoberfest swag and we will be sending instructions on how to redeem soon :) With Best Regards, Elmer |
|
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
|
@thinkingserious thanks :) I will fix the issues this weekend. |
|
@thinkingserious I moved code to the example but the travis build is failing, no idea why. |
|
Don't worry about the Travis failures, they are not related to your PR. Your PR is currently in our backlog for review. Thanks! With Best Regards, Elmer |
|
Final review needed to verify the functionality is correct. |
childish-sambino
changed the title
childish-sambino
changed the title
Fixes #260