Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixes Javadoc errors in Attachments.java #418

Merged
merged 4 commits into from
Nov 6, 2020

Conversation

pacbac
Copy link
Contributor

@pacbac pacbac commented Jan 17, 2018

Fixes #412

Description of what this PR fixes:

  • Adds @return for appropriate methods
  • Deleted an extra @param apiKey in attachments build()

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 17, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Jan 17, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Thanks @pacbac,

This is now on our backlog for review.

With Best Regards,

Elmer

@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty labels Sep 28, 2018
@childish-sambino childish-sambino removed the type: bug bug in the library label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:33
@childish-sambino childish-sambino changed the title Fixes Javadoc errors in Attachments.java and SendGridAPI.java docs: Fixes Javadoc errors in Attachments.java Nov 6, 2020
@childish-sambino childish-sambino merged commit baad444 into sendgrid:main Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javadoc failures during Travis Build - @param doesn't exist
4 participants