Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update build.gradle #471

Merged
merged 2 commits into from
Jul 29, 2019
Merged

chore: Update build.gradle #471

merged 2 commits into from
Jul 29, 2019

Conversation

doilio
Copy link
Contributor

@doilio doilio commented Oct 4, 2018

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Replace compile with implementation.
  • Replace testCompile with testImplementation.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 4, 2018

CLA assistant check
All committers have signed the CLA.

@thatfiredev
Copy link
Contributor

@doilio Circle CI build is failing here because this project is still using gradle 1.8. Update it to gradle 3.x or higher in order to use implementation.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: easy fix is easy in difficulty labels Oct 11, 2018
@thinkingserious
Copy link
Contributor

Hello @doilio,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@aroach
Copy link

aroach commented Oct 18, 2018

This may be fixed via #459 ? I think this could be closed actually since the PR seems to only update the gradle config.

@thinkingserious
Copy link
Contributor

Hello @doilio,

Thanks again for the PR!

We noticed that you have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @doilio,

Thanks again for the PR!

You have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@thinkingserious thinkingserious merged commit 444c0d4 into sendgrid:master Jul 29, 2019
@thinkingserious
Copy link
Contributor

Hello @doilio,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@eshanholtz eshanholtz changed the title Update build.gradle chore: Update build.gradle Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants