Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removed the apiKey instance variable as it wasn't being used #542

Merged
merged 2 commits into from
Feb 4, 2020
Merged

chore: Removed the apiKey instance variable as it wasn't being used #542

merged 2 commits into from
Feb 4, 2020

Conversation

RohanTalip
Copy link
Contributor

(A warning was showing in IntelliJ IDEA.)

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
    • Not applicable as there is no development branch yet.
  • I have added tests that prove my fix is effective or that my feature works
    • Not applicable.
  • I have added necessary documentation about the functionality in the appropriate .md file
    • Not applicable.
  • I have added in line documentation to the code I modified
    • Not applicable.

@RohanTalip
Removed the apiKey instance variable as it wasn't being used.
c1d986a 
(A warning was showing in IntelliJ IDEA.)
@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: easy fix is easy in difficulty status: hacktoberfest approved labels Oct 31, 2018
@childish-sambino childish-sambino changed the title Removed the apiKey instance variable as it wasn't being used. chore: Removed the apiKey instance variable as it wasn't being used Feb 4, 2020
@childish-sambino childish-sambino merged commit 8fc3514 into sendgrid:master Feb 4, 2020
@thinkingserious
Copy link
Contributor

Hello @RohanTalip,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@RohanTalip RohanTalip deleted the remove-unused-apikey branch February 4, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RohanTalip @thinkingserious @childish-sambino