Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception if a template ID does not exist in your request body #778

Closed
thinkingserious opened this issue Oct 6, 2018 · 4 comments
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Issue Summary

You will not receive an error from the API is you send an email with the wrong template. Instead you will get a "Not Delivered" notice in your email activity feed. We want to make that experience better by throwing an exception in the code instead.

This issue is inspired by this.

Acceptance Criteria

  • Use the API to verfiy a template ID exists, if not, throw an exception
  • A new test is added that demonstrates that if you use a non-existent template, the code will throw an error
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap labels Oct 6, 2018
@rishacha
Copy link

rishacha commented Oct 6, 2018

Hi, Can I take this up?

@mvarrieur
Copy link

I think your link to the API is incorrect in the description of this issue FYI

@10kc-zack
Copy link

@thinkingserious To confirm, would this change add another HTTP request when sending mail with @sendgrid/mail? If so, I don't agree that it should be the solution. In my mind, the SendGrid API should be changed to return a detailed error stating that the template ID doesn't exist.

@thinkingserious
Copy link
Contributor Author

Since there has been no activity on this issue since March 1, 2020, we are closing this issue. Please feel free to reopen or create a new issue if you still require assistance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

5 participants