Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update transactional-templates.md to use dynamicTemplateData instead of dynamic_template_data #1151

Merged
merged 1 commit into from Jun 22, 2020
Merged

docs: Update transactional-templates.md to use dynamicTemplateData instead of dynamic_template_data #1151

merged 1 commit into from Jun 22, 2020

Conversation

bttf
Copy link
Contributor

@bttf bttf commented Jun 21, 2020 •
edited

Fixes

This fixes a typo in the docs. It can lead devs down the wrong path. Related PR: #716

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 21, 2020
thinkingserious
thinkingserious approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thinkingserious thinkingserious merged commit 0c0bd1c into sendgrid:master Jun 22, 2020
@childish-sambino
Copy link
Contributor

I believe either casing works fine.

But anyway, @bttf Could you check the license acknowledgment in the PR summary?

@bttf
Copy link
Contributor Author

bttf commented Jun 24, 2020

I believe either casing works fine.

But anyway, @bttf Could you check the license acknowledgment in the PR summary?

Snake case was not working for me. I spent a while debugging. Checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
3 participants
@bttf @childish-sambino @thinkingserious