Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not wrap names with commas in quotes #1190

Merged
merged 1 commit into from Sep 3, 2020
Merged

fix: do not wrap names with commas in quotes #1190

merged 1 commit into from Sep 3, 2020

Conversation

eshanholtz
Copy link
Contributor

Fixes #1183

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 3, 2020
@eshanholtz eshanholtz merged commit 841ccd1 into main Sep 3, 2020
@eshanholtz eshanholtz deleted the fix-commas branch September 3, 2020 21:59
@256hz
Copy link

256hz commented Sep 15, 2020 •
edited

@eshanholtz This is great, and I confirmed it works locally. Any idea when it will be released? NPM doesn't support pinning a sub-package to a commit unfortunately.

@eshanholtz
Copy link
Contributor Author

@256hz The next release is scheduled for tomorrow, 2020-09-16 :)

@256hz
Copy link

256hz commented Sep 15, 2020

Great! Thanks for fixing this. It's been on the books for a while.

@eshanholtz eshanholtz mentioned this pull request Sep 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

from field wrap in quotes if there is a comma in
4 participants
@eshanholtz @256hz @childish-sambino @thinkingserious