Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken url on npmjs #1376

Merged
merged 1 commit into from
Dec 2, 2022
Merged

docs: Fix broken url on npmjs #1376

merged 1 commit into from
Dec 2, 2022

Conversation

umarfchy
Copy link
Contributor

@umarfchy umarfchy commented Nov 11, 2022

Fixes

Some of the links in the package's npmjs landing page are broken because of being referenced by the relative path. This pr updates the links by referencing the document using the URLs which resolves the issue.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@umarfchy umarfchy marked this pull request as ready for review November 11, 2022 16:22
@umarfchy
Copy link
Contributor Author

Hi @childish-sambino, would you mind taking a look into this? The PR requires approval from the maintainers to run the workflow. Thanks 🙂

@umarfchy
Copy link
Contributor Author

umarfchy commented Nov 14, 2022

@childish-sambino Thanks for approving the PR. It seems the failing tests are related to npm and not necessarily related to the PR itself which is only related to docs itself.

@umarfchy
Copy link
Contributor Author

@childish-sambino hope you're well. Would you kindly let me know the step I should take to pass all the tests from CI? Although the change was made only to the docs, it seems I need to do something else to make sure the rest of the tests pass. Thanks.

@childish-sambino childish-sambino merged commit 7d62da1 into sendgrid:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants