Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Deduplicate typechecks in setters #602

Merged
merged 6 commits into from Nov 5, 2020
Merged

chore: Deduplicate typechecks in setters #602

merged 6 commits into from Nov 5, 2020

Conversation

jstevans
Copy link
Contributor

@jstevans jstevans commented Nov 1, 2017 •
edited by childish-sambino

Fixes #553

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Refactor undefined checks, type checks, etc. into deduplicated functions
  • This actually only reduces LOC by 12, but this can be pretty easily moved to a shared file that can be used in other classes.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Nov 1, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

@jstevans

We can’t merge your PR without the CLA being signed.

[ ] Sign the CLA before November 3rd
[ ] Tag @mbernier and @thinkingserious to let us know it is signed

Then we will comment with a link to get your shirt!

@jstevans
Copy link
Contributor Author

jstevans commented Nov 3, 2017

@mbernier @thinkingserious Thanks!

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Mar 6, 2018
@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:34
@childish-sambino childish-sambino changed the title Deduplicate typechecks in setters chore: Deduplicate typechecks in setters Oct 12, 2020
@childish-sambino childish-sambino merged commit 84a3e76 into sendgrid:main Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
5 participants
@jstevans @SendGridDX @thinkingserious @childish-sambino @eshanholtz