Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#765 - Updating the troubleshooting.md #785

Merged
merged 4 commits into from
Oct 22, 2018
Merged

#765 - Updating the troubleshooting.md #785

merged 4 commits into from
Oct 22, 2018

Conversation

ssiddhantsharma
Copy link
Contributor

@ssiddhantsharma ssiddhantsharma commented Oct 7, 2018 •
edited

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@ssiddhantsharma @thinkingserious
sendgrid#765 - Updating the troubleshooting.md
bae6f26 
Added the sendgrid#692 multi line codes in <pre> turn to one line after mail send,
to the troubleshooting.md on your request.

Co-Authored-By: Elmer Thomas <elmer@thinkingserious.com>
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 7, 2018
@ssiddhantsharma
Copy link
Contributor Author

@thinkingserious Updated the troubleshoot file with your request.
#785

@ssiddhantsharma ssiddhantsharma mentioned this pull request Oct 7, 2018
Closed
6 tasks
reedsa
reedsa suggested changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've added some feedback.

TROUBLESHOOTING.md Outdated Show resolved Hide resolved
TROUBLESHOOTING.md Outdated Show resolved Hide resolved
TROUBLESHOOTING.md Outdated Show resolved Hide resolved
TROUBLESHOOTING.md Outdated Show resolved Hide resolved
@reedsa reedsa added status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 10, 2018
@devchas devchas added difficulty: medium fix is medium in difficulty type: community enhancement feature request not on Twilio's roadmap hacktoberfest labels Oct 11, 2018
@ssiddhantsharma
Updated with revised changes!
1023885 
@reedsa Updated the file with your requested changes!
@ssiddhantsharma
Copy link
Contributor Author

@reedsa Updated the file with required changes. Thank you for reviewing this one.

reedsa
reedsa suggested changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things to clean up, then I'm happy to approve. Thanks!

TROUBLESHOOTING.md Outdated Show resolved Hide resolved
TROUBLESHOOTING.md Outdated Show resolved Hide resolved
reedsa
reedsa approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the contribution!

@reedsa reedsa added status: ready for deploy code ready to be released in next deploy and removed status: waiting for feedback waiting for feedback from the submitter labels Oct 19, 2018
@thinkingserious thinkingserious merged commit c445f1d into sendgrid:master Oct 22, 2018
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reedsa reedsa reedsa approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ssiddhantsharma @reedsa @thinkingserious @devchas