New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace Travis-CI with GitHub Actions #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis is being removed from all Twilio SendGrid repos in favor of alternative build tools.
Buildkite PR
GH Actions does not work with this commit. Files have been added to be built in future commits.
Node and npm are not required separately when using the Spectral Action provided by Stoplight, which runs linting in a Docker container.
Uses Makefile rather than Spectral GH Action. Updates contribution instructions.
The last commit sets it to lint only the v3 spec. It's failing but should pass once we pull in PRs to sync this with the other spec work Elmer is doing. |
shwetha-manvinkurke
changed the title
Replace Travis-CI with GitHub Actions
chore: Replace Travis-CI with GitHub Actions
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make sure the v3 spec lints fine with spectral before this PR is merged?
shwetha-manvinkurke
approved these changes
Nov 19, 2021
This was referenced Nov 19, 2021
thinkingserious
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test!:
These changes should start to bring the CI/CD pipeline in line with the Twilio OAI repo, which has moved off Travis and onto GitHub Actions.
Spectral lint currently fails. All oai files are being linted, several of which need to have multiple errors addressed.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.