Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace Travis-CI with GitHub Actions #98

Merged
merged 27 commits into from Nov 19, 2021
Merged

Conversation

wadethemaker
Copy link

@wadethemaker wadethemaker commented Nov 15, 2021

test!:

  1. Replaces Travis-CI with GitHub Actions.h
  2. Replaces Prance validator with Spectral linter.
  3. Updates README and CONTRIBUTING. This project is in pre-pilot and should not currently be relied on. This project will be generated by tooling and will not be able to accept public PRs in the near future.

These changes should start to bring the CI/CD pipeline in line with the Twilio OAI repo, which has moved off Travis and onto GitHub Actions.

Spectral lint currently fails. All oai files are being linted, several of which need to have multiple errors addressed.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@wadethemaker wadethemaker marked this pull request as draft November 15, 2021 22:47
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
spectral.yaml Outdated Show resolved Hide resolved
Uses Makefile rather than Spectral GH Action.
Updates contribution instructions.
@wadethemaker
Copy link
Author

The last commit sets it to lint only the v3 spec. It's failing but should pass once we pull in PRs to sync this with the other spec work Elmer is doing.

@wadethemaker wadethemaker marked this pull request as ready for review November 17, 2021 21:32
@shwetha-manvinkurke shwetha-manvinkurke changed the title Replace Travis-CI with GitHub Actions chore: Replace Travis-CI with GitHub Actions Nov 17, 2021
.github/workflows/ahoy.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
spectral.yaml Outdated Show resolved Hide resolved
.github/workflows/ahoy.yml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure the v3 spec lints fine with spectral before this PR is merged?

@wadethemaker wadethemaker marked this pull request as draft November 19, 2021 16:58
@thinkingserious thinkingserious merged commit 5333f23 into main Nov 19, 2021
@thinkingserious thinkingserious deleted the github-actions branch November 19, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants