Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach files to email from Box.com #481

Closed
thinkingserious opened this issue Oct 16, 2017 · 2 comments · Fixed by #743
Closed

Attach files to email from Box.com #481

thinkingserious opened this issue Oct 16, 2017 · 2 comments · Fixed by #743
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 16, 2017 •
edited

This should be added to the Mail helper method (unless a new dependency is required, in that case describe the usage in the USE_CASES.md file), where the file that is attached can be sitting in Box.com storage.

In most circumstances, for Spam detection reasons, it would be better to link to the file- however, there are legitimate use cases for attaching a file. Example: Receipt PDFs
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 16, 2017
@mbernier mbernier removed difficulty: hard fix is hard in difficulty difficulty: medium fix is medium in difficulty difficulty: very hard fix is very hard in difficulty labels Oct 27, 2017
@thinkingserious thinkingserious added status: help wanted requesting help from the community difficulty: medium fix is medium in difficulty up-for-grabs type: docs update documentation change not affecting the code labels Feb 27, 2018
@semijoelon
Copy link
Contributor

I'll work on this issue.

@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing and removed help wanted status: help wanted requesting help from the community labels Oct 16, 2018
@thinkingserious
Copy link
Contributor Author

Thank you @semijoelon, it’s all yours!

semijoelon added a commit to semijoelon/sendgrid-php that referenced this issue Oct 17, 2018
@semijoelon
Added Box attachment example (issue sendgrid#481)
d24970c
@semijoelon semijoelon mentioned this issue Oct 17, 2018
Merged
6 tasks
thinkingserious added a commit that referenced this issue Oct 22, 2018
@thinkingserious
Merge pull request #743 from semijoelon/box-file-attach
dc9dba2 
Added Box attachment example (issue #481)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Box attachment example (issue #481) semijoelon/sendgrid-php
3 participants
@thinkingserious @mbernier @semijoelon