Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a .env_sample file #520

Closed
thinkingserious opened this issue Oct 27, 2017 · 1 comment
Closed

Add a .env_sample file #520

thinkingserious opened this issue Oct 27, 2017 · 1 comment
Labels
difficulty: easy fix is easy in difficulty

Comments

@thinkingserious
Copy link
Contributor

Our preference is that users have an environment file when using the SendGrid API, because it is less likely that someone would commit their credentials to github.

Please make a couple changes:

  • make a .env_sample file that contains: export SENDGRID_API_KEY=''
  • make (or add) a .gitignore file and include .env
  • add instructions to the README file about how to copy .env_sample to .env and add the API Key
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 27, 2017
@yeoji
Copy link
Contributor

yeoji commented Oct 27, 2017

I have created a PR for this issue

@mbernier mbernier removed difficulty: hard fix is hard in difficulty difficulty: medium fix is medium in difficulty difficulty: very hard fix is very hard in difficulty labels Oct 27, 2017
mbernier pushed a commit that referenced this issue Oct 29, 2017
Merge pull request #523 from yeoji/sampleenv
d04707c 
Added sample env file #520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thinkingserious @mbernier @yeoji