Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type validations to each setter and implement SendGrid custom exceptions #612

Closed
thinkingserious opened this issue May 19, 2018 · 2 comments · Fixed by #652
Closed
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Issue Summary

The correct types should be documented in phpdoc format already in the source code, but this documentation can be used to double check the types. If the type is incorrect we should throw a custom exception.

This feature should be added to the objects here.

@thinkingserious thinkingserious added status: help wanted requesting help from the community difficulty: medium fix is medium in difficulty up-for-grabs type: twilio enhancement feature request on Twilio's roadmap labels May 19, 2018
@thinkingserious thinkingserious changed the title Add type validations to each setter Add type validations to each setter and implement SendGrid custom exceptions May 19, 2018
@hjmsw
Copy link
Contributor

hjmsw commented Jul 28, 2018

I can have a look at this :)

@doctorpepper608
Copy link

doctorpepper608 commented Jan 23, 2020

@thinkingserious @hjmsw maybe filter_var($email, FILTER_VALIDATE_EMAIL) in in Mail->setFrom($email, $name=null) method should be parameterized , because validation disallow VALID email addresses [localdomain]@domain.com where [localdomain] is more than 64 characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants