Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #612 Add TypeException and include type validations in classes inside mail/ #652

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

hjmsw
Copy link
Contributor

@hjmsw hjmsw commented Jul 29, 2018

Fixes #612

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Added a TypeException class and added validation in class setters inside mail/

Ran tests and added * @expectedException \SendGrid\Mail\TypeException where needed where test threw an exception.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jul 29, 2018
@thinkingserious
Copy link
Contributor

Thanks for the contribution @hjmsw! I've added this to our backlog for review.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty labels Aug 7, 2018
@thinkingserious thinkingserious merged commit 2318abd into sendgrid:master Aug 14, 2018
@thinkingserious
Copy link
Contributor

Hello @hjmsw,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type validations to each setter and implement SendGrid custom exceptions
2 participants