PSR1 and PSR2 Conversion #319
Conversation
With the flags: align_double_arrow,short_echo_tag,line_after_namespace,long_array_syntax,no_blank_lines_before_namespace,ordered_use
With the flags: align_double_arrow,short_echo_tag,line_after_namespace,long_array_syntax,no_blank_lines_before_namespace,ordered_use
thinkingserious
added
type: community enhancement
|
Hello @Braunson, This is awesome! Thanks for your contribution! I will look into why the tests are failing. Could you please take a moment to sign our CLA so I can merge your changes? Thanks! |
|
CLA received, thanks! |
|
Definitely on board for ditching PEAR for PHP FIG recommendations for coding style conventions. Although, it looks like this PR, is reverting from the short array syntax back to the long array syntax. From what I can work out, PSR-2 does not seem to make an explicit decision on the short array syntax. However, they do use it in examples in Chapter 4.3. According to the PHP docs, unless the intention is for the library to have backward compatibility to support PHP < 5.4, there doesn't seem to be much benefit. |
|
Thanks for taking the time to provide some feedback! We do not support versions < 5.4 and do not plan to. That said, the long array syntax does not seem to hurt anything and would probably be helpful to those who must run a version < 5.4. Do you have a strong opinion on why we should revert to the long array syntax? |
|
@thinkingserious I'd actually prefer the shorter array syntax but as you said the longer is compatible for people who must run < 5.4. However according to current stats, the usage as of May 2016 for 5.4 and below is ~8% and rapidly dropping. I'll adjust the PR to the shorter syntax! Edit: Done 👍 |
|
Hello @Braunson, This issue has finally risen to the top of our queue! I notice that we have a conflicting file, could you please resolve? Thanks! Elmer |
|
@SendGridDX I'm not sure if I can edit this PR anymore, the original fork was deleted.
Edit: Seems this PR is an orphan now 😞 |
|
@SendGridDX Since I can't edit this PR, I've created a new one from a new fork with the same changes, it should pass tests. You can find the new PR here #373 . Probably best to close this PR now. |
Reference issue #317.
Tried to run tests on current master copy in addition to this PR version, kept getting errors referencing
Class SendGridandClass SendGrid\Clientnot found. I'm going to assume it's related to this #91