Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Google App engine installation with composer instructions #510

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Adding Google App engine installation with composer instructions #510

merged 1 commit into from
Dec 20, 2017

Conversation

nalinbhardwaj
Copy link
Contributor

Adds php.ini file instructions to both files USE_CASES.md and TROUBLESHOOTING.md

Fixes #423

@thinkingserious please review.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 22, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 22, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

@nalinbhardwaj

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@nalinbhardwaj
Copy link
Contributor Author

nalinbhardwaj commented Nov 2, 2017

@thinkingserious , thanks a lot, but I already filled this form for a PR on the docs repository, I don’t need to fill it again right?

Thanks for the swag though!

@thinkingserious
Copy link
Contributor

@nalinbhardwaj,

No, you don't need to fill it out again. Sorry for the duplicate request, we are just trying to make sure we don't miss anyone :)

Copy link

@m1guelpf m1guelpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work

@mbernier mbernier merged commit 2884aae into sendgrid:master Dec 20, 2017
@thinkingserious
Copy link
Contributor

Hello @nalinbhardwaj,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@nalinbhardwaj nalinbhardwaj deleted the GAE-instructions branch December 20, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants