Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for commas and semicolons in email name and add test #511

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Add support for commas and semicolons in email name and add test #511

merged 1 commit into from
Mar 28, 2018

Conversation

qligier
Copy link
Contributor

@qligier qligier commented Oct 22, 2017

This PR fixes issue #368 and replaces #370. It wraps the email name in double quotes when commas or semicolons are present (without, the mail would be rejected by the API).

I've added unit test to check the behavior of the Sendgrid\Email->setName() method. I've also sent real emails with various names to verify that they are delivered.

I've also added a comment explaining the issue because the patch should be reverted if the API is modified to support commas and semicolons.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 22, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 22, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

@qligier

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@qligier
Copy link
Contributor Author

qligier commented Nov 3, 2017

Hey,
Thanks for the shirt!
Why haven't you been able to merge it? Does it require some changes?

@thinkingserious
Copy link
Contributor

Hello @qligier,

I'm not sure if your PR will require any changes just yet. We are processing all of the PRs from oldest to newest and we had over 1,000 PRs this hacktoberfest, so we are a bit (OK, a lot) behind :)

Thank you for your contribution and patience!

With Best Regards,

Elmer

@thinkingserious thinkingserious added the type: twilio enhancement feature request on Twilio's roadmap label Feb 28, 2018
Copy link
Contributor

@ssiddhantsharma ssiddhantsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test really lives up, and performs the job well.

@thinkingserious
Copy link
Contributor

Hello @qligier,

Could you please resolve the conflicts so that I can merge this? Thanks!

@qligier
Copy link
Contributor Author

qligier commented Mar 28, 2018

It's done. There is an issue with composer when using PHP 7 but tests have passed with PHP 5.6 in Travis CI.

@thinkingserious thinkingserious merged commit 02b4840 into sendgrid:master Mar 28, 2018
@thinkingserious
Copy link
Contributor

Hello @qligier,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

childish-sambino pushed a commit that referenced this pull request Sep 23, 2020
The backend has been updated to properly handling names with special characters so the original "fix" is no longer needed.

Reverts #511
childish-sambino pushed a commit that referenced this pull request Sep 23, 2020
The backend has been updated to properly handling names with special characters so the original "fix" is no longer needed.

Reverts #511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants