Omit PHP closing tag in use case sample #512
Conversation
Per http://php.net/manual/en/language.basic-syntax.phptags.php it's best to omit PHP closing tags when a code file is pure PHP to avoid to accidentally send whitelines to the buffer output, before headers could be sent. As such, documentation should not use closing tags to reflect best practices.
thinkingserious
added
the
status: code review request
|
|
|
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
thinkingserious
added
type: community enhancement
There was a problem hiding this comment.
Well it is really a DRUPAL or WORDPRESS thing but in some cases omitting the tag is helpful as in, when using include() or require(), so no unwanted whitespaces will be there and you will still be able to add headers to the response later. It is generally a good practice but we should not dive so deep into it.
|
Hello @dereckson, |
Per http://php.net/manual/en/language.basic-syntax.phptags.php it's best to
omit PHP closing tags when a code file is pure PHP to avoid to accidentally
send whitelines to the buffer output, before headers could be sent.
As such, documentation should not use closing tags to reflect best practices.