Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 7.1 and 7.2 to Travis build matrix #565

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Add PHP 7.1 and 7.2 to Travis build matrix #565

merged 2 commits into from
Mar 12, 2018

Conversation

emirb
Copy link
Contributor

@emirb emirb commented Dec 5, 2017

No description provided.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Dec 5, 2017
@SendGridDX
Copy link

SendGridDX commented Dec 5, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Thanks @emirb,

This looks good at first glance. The failing tests are not related to your PR. I have added this to our backlog for final review and merge.

With Best Regards,

Elmer

@emirb emirb closed this Jan 29, 2018
@thinkingserious
Copy link
Contributor

Hello @emirb,

Just wondering why you closed this PR? It's still on our backlog for review and merge.

With Best Regards,

Elmer

@emirb emirb reopened this Feb 5, 2018
@emirb
Copy link
Contributor Author

emirb commented Feb 5, 2018

Reopened now — I just didn't want it open for 2 months without any activity so I cleaned up my profile a little bit last week.

@thinkingserious
Copy link
Contributor

Thanks @emirb!

@thinkingserious
Copy link
Contributor

Thanks for taking the time to code review @ssiddhantsharma!

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: easy fix is easy in difficulty labels Feb 28, 2018
@emirb
Copy link
Contributor Author

emirb commented Mar 5, 2018

Total of 4 months now

@thinkingserious
Copy link
Contributor

Thank you for your continued patience @emirb,

We are continuing to work through the over 1,000 Hacktoberfest PRs and we are currenlty down to less than 300 so far. I don't see any issue with merging this one when it comes up next on our backlog.

With Best Regards,

Elmer

@thinkingserious thinkingserious merged commit 1e3af0b into sendgrid:master Mar 12, 2018
@thinkingserious
Copy link
Contributor

Hello @emirb,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@emirb
Copy link
Contributor Author

emirb commented Mar 12, 2018

Thanks @thinkingserious! :)

@emirb emirb deleted the patch-1 branch March 12, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants