Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check so that getContents() always returns content with MimeType text/plain first in array of Content objects #626

Merged
merged 3 commits into from
Aug 6, 2018

Conversation

hjmsw
Copy link
Contributor

@hjmsw hjmsw commented Jun 8, 2018

Fixes #608

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.

Short description of what this PR does:

Ensures that when getContents() is called, returned array always includes Content object with MimeType 'text/plain' first.

…text/plain first in array of Content objects
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 8, 2018
@SendGridDX
Copy link

SendGridDX commented Jun 8, 2018

CLA assistant check
All committers have signed the CLA.

@hjmsw
Copy link
Contributor Author

hjmsw commented Jun 10, 2018

  • I have added tests that prove my fix is effective or that my feature works

@thinkingserious thinkingserious merged commit a0d80c9 into sendgrid:master Aug 6, 2018
@thinkingserious
Copy link
Contributor

Hello @hjmsw,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants