Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING - contribution guideline to branch off development #736

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Update CONTRIBUTING - contribution guideline to branch off development #736

merged 1 commit into from
Oct 29, 2018

Conversation

myzeprog
Copy link
Contributor

@myzeprog myzeprog commented Oct 13, 2018 •
edited

Fixes #733

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Update CONTRIBUTING - contribution guideline to branch off development

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 13, 2018
peter279k
peter279k reviewed Oct 16, 2018
View reviewed changes
CONTRIBUTING.md
@@ -59,6 +59,8 @@ In order to make the process easier, we've included a [sample bug report templat

We welcome direct contributions to the sendgrid-php code base. Thank you!

Please note that we utilize the [Gitflow Workflow](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow) for Git to help keep project development organized and consistent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using the Gitflow is more complicated than GitHubflow workflow.
And it isn't also friendly for the new-welcome contributors.

Please take a look at that post.

@devchas devchas added difficulty: easy fix is easy in difficulty good first issue type: docs update documentation change not affecting the code status: work in progress Twilio or the community is in the process of implementing labels Oct 17, 2018
@thinkingserious thinkingserious added status: ready for deploy code ready to be released in next deploy status: hacktoberfest approved and removed status: code review request requesting a community code review or review from Twilio status: work in progress Twilio or the community is in the process of implementing labels Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @myzeprog,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 4c6b3f9 into sendgrid:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter279k peter279k peter279k left review comments

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document new Git workflow in CHANGELOG.md
4 participants
@myzeprog @thinkingserious @peter279k @devchas