Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example.php. Add personalization example as per #792 #836

Merged
merged 1 commit into from
May 21, 2019
Merged

Update example.php. Add personalization example as per #792 #836

merged 1 commit into from
May 21, 2019

Conversation

hjmsw
Copy link
Contributor

@hjmsw hjmsw commented May 10, 2019

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Fixes #792
Added missing example of how to use personalization index.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 10, 2019
@hjmsw hjmsw mentioned this pull request May 10, 2019
Merged
7 tasks
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code labels May 21, 2019
@thinkingserious thinkingserious merged commit e27cde8 into sendgrid:master May 21, 2019
@thinkingserious
Copy link
Contributor

Hello @hjmsw,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add personalization index example to kitchen sink
2 participants
@hjmsw @thinkingserious