Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve deprecation notices when using Composer 1.10(-dev) #918

Merged
merged 1 commit into from Feb 13, 2020

Conversation

kampalex
Copy link
Contributor

@kampalex kampalex commented Dec 6, 2019

Deprecation Notices caused by unneeded 'SendGrid\' psr-4 autoload
Deprecation Notices caused by /test subdirectories: same namespace in different directories
Remaining Deprecation Notices by invalid class names
(Executed PHPUnit tests using Prism, but ignored results due to unknown status of working SendGrid API functions or test results caused by older PHPUnit version)

Fixes #906

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Composer.json: Removed unneeded PSR-4 autoload entry to load the 'lib/' directory.
  • Adjusted namespace of files in 'test/' to comply with PSR-4 class loading
  • Renamed some test files which contains different class name

If you have questions, please send an email to Twilio Sendgrid, or file a Github Issue in this repository.

Deprecation Notices caused by unneeded 'SendGrid\\' psr-4 autoload
Deprecation Notices caused by /test subdirectories: same namespace in different directories
Remaining Deprecation Notices by invalid class names
(Executed PHPUnit tests using Prism, but ignored results due to unknown status of working SendGrid API functions or test results caused by older PHPUnit version)
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Dec 6, 2019
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino changed the title Fixes for Composer 1.10(-dev) fix: resolve deprecation notices when using Composer 1.10(-dev) Feb 13, 2020
@childish-sambino childish-sambino merged commit 167e699 into sendgrid:master Feb 13, 2020
@thinkingserious
Copy link
Contributor

Hello @kampalex,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@kampalex kampalex deleted the kampalex-composer110dev branch February 19, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
3 participants