Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for sendgrid.py apikey and api_key setters #425

Merged
merged 1 commit into from Oct 28, 2017

Conversation

lafentres
Copy link
Contributor

@lafentres lafentres commented Oct 23, 2017

Addresses #419

I added tests for the two api key setter methods in sendgrid.py (apikey and api_key).

@mbernier edit: closes #419

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 23, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 23, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Oct 23, 2017

Codecov Report

Merging #425 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #425     +/-   ##
=========================================
+ Coverage   81.54%   81.75%   +0.2%     
=========================================
  Files           9        9             
  Lines         981      981             
  Branches      156      156             
=========================================
+ Hits          800      802      +2     
+ Misses         90       88      -2     
  Partials       91       91
Impacted Files Coverage Δ
sendgrid/sendgrid.py 100% <0%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0884519...2e85c52. Read the comment docs.

@lafentres
Copy link
Contributor Author

@mbernier , For some reason this won't update showing that I've signed the CLA. You can see that I did sign it on my previous pull request though (#424)

@thinkingserious
Copy link
Contributor

Hi @lafentres,

What happens when you click the CLA link?

Thanks!

Elmer

@lafentres
Copy link
Contributor Author

Hi, @thinkingserious

When I click the CLA link, it shows me the CLA that I filled out (see screenshot below).
screen shot 2017-10-25 at 12 24 40 pm

I also tried clicking recheck several times but it just redirects me back here without changing the CLA status.

@thinkingserious
Copy link
Contributor

Hi @lafentres,

Could you please try again with this link?

Thanks!

@mbernier
Copy link
Contributor

Hey @lafentres I can see in the backend that you have signed the CLA for this repo. We should be g2g without the check going through
CLA signed

@thinkingserious
Copy link
Contributor

@lafentres,

I see the issue, this PR was made with a commit from user klafentres. You can either login as that user, if its a GitHub user, or make a new PR with the commits coming from your lafentres account.

With Best Regards,

Elmer

@lafentres
Copy link
Contributor Author

@thinkingserious , @mbernier Thanks for checking this for me. I'm not sure what's up with my local git setup but I signed into my other account and signed the CLA there as well. Sorry for all the confusion!

@mbernier
Copy link
Contributor

No worries at all! Thank you for your contributions and for all your feedback, we VERY MUCH appreciate it!

@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest and removed status: cla needed labels Oct 28, 2017
@mbernier mbernier merged commit 724fedc into sendgrid:master Oct 28, 2017
@thinkingserious
Copy link
Contributor

Hello @lafentres,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
5 participants