Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#445] Added PULL_REQUEST_TEMPLATE #446

Merged
merged 1 commit into from Oct 28, 2017
Merged

[#445] Added PULL_REQUEST_TEMPLATE #446

merged 1 commit into from Oct 28, 2017

Conversation

s0b0lev
Copy link
Contributor

@s0b0lev s0b0lev commented Oct 26, 2017

No description provided.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 26, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 26, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Oct 26, 2017

Codecov Report

Merging #446 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #446   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files           9        9           
  Lines         999      999           
  Branches      160      160           
=======================================
  Hits          823      823           
  Misses         86       86           
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c422e2...21d6b97. Read the comment docs.

@Xndr7
Copy link

Xndr7 commented Oct 26, 2017

Hi.
Maybe you could refer to this file for more details that can be added to the template.
Since the maintainers suggested it in #445.
Cheers! 👍

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 27, 2017
**Description of the change**:

**Reason for the change**:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a couple more things? @Xndr7 noted, this is a really good example -
you can copy/pasta it here if you would like!
https://github.com/sendgrid/open-source-library-data-collector/blob/master/.github/PULL_REQUEST_TEMPLATE.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#456 resolves this comment.

Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a couple more things!

@mbernier mbernier merged commit 90ae965 into sendgrid:master Oct 28, 2017
@thinkingserious
Copy link
Contributor

Hello @s0b0lev,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
6 participants