Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix issues in sendgrid/helpers/mail/mail.py #496

Closed
wants to merge 6 commits into from

Conversation

galihmelon
Copy link

Fixes

Fixes #457
Fixes #458

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Another attempt to decrease Cognitive Complexity of function
  • Another attempt to deduplicate similar blocks of code
  • Revert private variables to be public if they do not need mutations during setting/getting

galihmelon added 3 commits October 29, 2017 22:26
…ilar blocks of code; revert private variables to be public if they do not need mutations during setting/getting
…ilar blocks of code; revert private variables to be public if they do not need mutations during setting/getting
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Oct 29, 2017

Codecov Report

Merging #496 into master will decrease coverage by 1.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
- Coverage      83%   81.83%   -1.18%     
==========================================
  Files          30       30              
  Lines        1024      936      -88     
  Branches      160      133      -27     
==========================================
- Hits          850      766      -84     
  Misses         84       84              
+ Partials       90       86       -4
Impacted Files Coverage Δ
sendgrid/helpers/mail/mail.py 100% <100%> (+2.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec799f...b7f759b. Read the comment docs.

@thinkingserious
Copy link
Contributor

@galihmelon

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@thinkingserious thinkingserious added the type: twilio enhancement feature request on Twilio's roadmap label Feb 27, 2018
thinkingserious added a commit that referenced this pull request Jul 25, 2018
@thinkingserious
Copy link
Contributor

Thanks again for helping improve this SDK!

We have started to execute on PR #347 (Python Mail Helper Refactor) and have integrated your work into this branch. Please follow along at PR #347 to follow our progress.

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
5 participants