Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shadowed builtins, id -> id_ #533

Merged
merged 1 commit into from May 30, 2018
Merged

Fix shadowed builtins, id -> id_ #533

merged 1 commit into from May 30, 2018

Conversation

delirious-lettuce
Copy link
Contributor

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@gabrielkrell
Copy link
Contributor

id is one of those functions that I wish was named differently, just because it's such a common variable name compared to how often the function is used. Oh well, +1

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Feb 27, 2018
@thinkingserious thinkingserious merged commit deefcd6 into sendgrid:master May 30, 2018
@thinkingserious
Copy link
Contributor

Hello @delirious-lettuce,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library type: docs update documentation change not affecting the code
Projects
None yet
4 participants