helpers.Mail: warn on incorrect invocation #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invocations like `Mail(from_email=Email('express@example.com'), subject=subject, to_email=Email(to))` silently discard all parameters. Took me several hours to debug this. I'm not sure why the library is designed that way. But I thought it would be nice to warn the caller if parameters are discarded.
thinkingserious
added
the
status: code review request
|
|
|
Thank you @mdornseif! I have added this to our backlog for a code review. With Best Regards, Elmer |
thinkingserious
added
type: community enhancement
|
This will be obsolete after merging #554 |
|
That is true @3lnc, thanks for the heads up. We still appreciate your contribution @mdornseif and would like to offer you some swag. With Best Regards, Elmer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invocations like
Mail(from_email=Email('express@example.com'), subject=subject, to_email=Email(to))silently discard all parameters. Took me several hours to debug this. I'm not sure why the library is designed that way. But I thought it would be nice to warn the caller if parameters are discarded.Fixes
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.