Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README.md #683

Merged
merged 10 commits into from Oct 30, 2018
Merged

Create README.md #683

merged 10 commits into from Oct 30, 2018

Conversation

tulikavijay
Copy link
Contributor

Fixes

Fixes : #566

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Add readme for using helpers and understanding examples

Note : I want to know if i am going in the right direction with this PR.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 16, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 16, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #683 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #683   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          980      980           
  Misses         90       90           
  Partials       86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b68316...f4ac98c. Read the comment docs.

@devchas devchas added hacktoberfest difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Oct 17, 2018
Copy link
Contributor

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the new GitHub "suggested change" feature here! Just some punctuation and capitalization fix-ups, please. Thanks for getting some initial documentation done on this!

examples/helpers/README.md Outdated Show resolved Hide resolved
examples/helpers/README.md Outdated Show resolved Hide resolved
examples/helpers/README.md Outdated Show resolved Hide resolved
examples/helpers/README.md Outdated Show resolved Hide resolved
examples/helpers/README.md Outdated Show resolved Hide resolved
examples/helpers/README.md Outdated Show resolved Hide resolved
examples/helpers/README.md Outdated Show resolved Hide resolved
examples/helpers/README.md Outdated Show resolved Hide resolved
@misterdorm
Copy link
Contributor

You'll also need to agree to the CLA before this can be merged. Click 'details' on the 'license/cla' check above to do so. Thanks!

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing status: cla not signed and removed status: code review request requesting a community code review or review from Twilio labels Oct 19, 2018
misterdorm and others added 8 commits October 20, 2018 21:27
Co-Authored-By: tulikavijay <fictionfree54@gmail.com>
Co-Authored-By: tulikavijay <fictionfree54@gmail.com>
Co-Authored-By: tulikavijay <fictionfree54@gmail.com>
Co-Authored-By: tulikavijay <fictionfree54@gmail.com>
Co-Authored-By: tulikavijay <fictionfree54@gmail.com>
Co-Authored-By: tulikavijay <fictionfree54@gmail.com>
Co-Authored-By: tulikavijay <fictionfree54@gmail.com>
Co-Authored-By: tulikavijay <fictionfree54@gmail.com>
@tulikavijay
Copy link
Contributor Author

This is an awesome feature! Thanks for the review!

@thinkingserious
Copy link
Contributor

Hello @tulikavijay,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @tulikavijay,

Thanks again for the PR!

We noticed that you have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious thinkingserious merged commit d3791b0 into sendgrid:master Oct 30, 2018
@thinkingserious
Copy link
Contributor

Hello @tulikavijay,

Thanks again for the PR!

You have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code
Projects
None yet
5 participants