Dockerize #181
Dockerize #181
Conversation
thinkingserious
added
the
status: code review request
|
|
|
|
||
| ## Quickstart | ||
| 1. [Install Docker](https://docs.docker.com/engine/installation/) on your machine. | ||
| 2. Run `docker run --rm -it sendgrid/sendgrid-ruby irb`. |
There was a problem hiding this comment.
The idea was to get a interpretor where a dev could try out the gem without having to run it.
|
|
||
| If you want to mount your fork or specific version of the gem: | ||
| ```sh | ||
| docker run --rm -v /path/to/local/sendgrid-ruby:/sources/sendgrid-ruby -it sendgrid/sendgrid-ruby bash |
There was a problem hiding this comment.
Would you be up for adding a docker-compose file that would make the ruby gems and source code local to the machine the container is running on?
There was a problem hiding this comment.
Will the volumes not be sufficient for this?
| docker run --rm -v /path/to/local/sendgrid-ruby:/sources/sendgrid-ruby -it sendgrid/sendgrid-ruby bash | ||
| ``` | ||
|
|
||
| ## Running tests |
|
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
|
Hello @shrivara, |
|
If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries. Our agenda would be: Explore what you liked and is there anything we can do to improve? You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain. Thank you so much, Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager |
This covers the basic cases of working on the gem and running tests. I just wanted to get a quick review to understand what else is required.
#179
@mbernier edit: resolves #179