Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This patch implements get unassigned IPs example #216

Merged

Conversation

cristianossd
Copy link
Contributor

It's about #214

@SendGridDX
Copy link

SendGridDX commented Oct 17, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 22, 2017
@thinkingserious
Copy link
Contributor

@cristianossd

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@cristianossd
Copy link
Contributor Author

@thinkingserious, thanks so much for that! But, could I modify this PR to have a merge?

@thinkingserious
Copy link
Contributor

Hi @cristianossd,

My apologies for the delay, we are working through the PRs in order and its taking much longer than usual due to a tremendous hacktoberfest where we received over 1,000 PRs in October.

We appreciate your support and patience!

With Best Regards,

Elmer

Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clee clee added triaged and removed status: code review request requesting a community code review or review from Twilio triaged labels Feb 12, 2018
@thinkingserious thinkingserious added type: twilio enhancement feature request on Twilio's roadmap status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
@thinkingserious thinkingserious merged commit b8fb5c2 into sendgrid:master Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @cristianossd,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @cristianossd,

Thanks again for the PR!

You have earned 6 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants