Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Code Review to Contributing.md #268

Merged
merged 2 commits into from
Oct 22, 2018
Merged

Added Code Review to Contributing.md #268

merged 2 commits into from
Oct 22, 2018

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Oct 31, 2017 •
edited
Loading

Fixes #267

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added Code Review to Contributing.md

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@mptap mptap mentioned this pull request Oct 31, 2017
Closed
@mrmuskrat
Copy link

Looks good to me.

@rahul26goyal
Copy link
Contributor

LGTM

clee
clee reviewed Feb 12, 2018
View reviewed changes
Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clee clee added triaged and removed status: code review request requesting a community code review or review from Twilio triaged labels Feb 12, 2018
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
@thinkingserious thinkingserious merged commit cdbb3c2 into sendgrid:master Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @mptap,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clee clee clee left review comments

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Code Review to Contributing.md
6 participants
@mptap @mrmuskrat @rahul26goyal @thinkingserious @clee @mbernier