Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to impersonate subuser #271

Merged
merged 2 commits into from
Oct 22, 2018

Conversation

danilospa
Copy link
Contributor

Resolves #270

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • It enables a impersonate_subuser parameter on client initialize function. When it's filled, the header On-Behalf-Of is added.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@SendGridDX
Copy link

SendGridDX commented Nov 1, 2017

CLA assistant check
All committers have signed the CLA.

@danilospa
Copy link
Contributor Author

The following tests are breaking because corresponding files do not exist:
test_docker_compose_exists, test_docker_exists, test_codeclimate_exists.
May I remove these tests on this same PR?

@jagthedrummer
Copy link

I'd love to see this get merged.

@thinkingserious
Copy link
Contributor

Thanks for the vote @jagthedrummer!

This PR is on our backlog to merge and your vote helps give it priority.

@clee
Copy link

clee commented Feb 12, 2018

LGTM - this PR is almost identical to #272, but I think the tests in this one are slightly better. I'd vote we merge this one.

@clee clee added triaged and removed status: code review request requesting a community code review or review from Twilio triaged labels Feb 12, 2018
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
@thinkingserious thinkingserious merged commit 6a9a943 into sendgrid:master Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @danilospa,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@Shadowssong
Copy link

Hi @thinkingserious do you know when the next release plans to happen? I would like to use this feature but its only on master and has not been released yet (as far as I can tell).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to impersonate a subuser
6 participants