Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-274: Fix travis warning #277

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Conversation

rahul26goyal
Copy link
Contributor

Fixes #274

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Remove duplicate declaration on name variable from category.rb
  • Remove unused variable from stat_response.rb.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 2, 2017
@thinkingserious
Copy link
Contributor

Hi @rahul26goyal ,

Generally, a combination of examining the local test results vs the Travis CI logs does the trick.

@rahul26goyal
Copy link
Contributor Author

hi @thinkingserious
Three unit tests on travis are failing.

@thinkingserious
Copy link
Contributor

Hi @rahul26goyal,

Yes, those tests are expected to fail for now, they will not effect the merging of your PR. We are currently behind schedule in closing PRs right now due to an amazing flood of over 1,000 PRs last month for Hacktoberfest.

We appreciate your patience as we work through the backlog.

With Best Regards,

Elmer

Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clee clee added triaged and removed status: code review request requesting a community code review or review from Twilio triaged labels Feb 12, 2018
@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
@thinkingserious thinkingserious merged commit 351c5b1 into sendgrid:master Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @rahul26goyal,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable issues in testing
3 participants