Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dynamic template data. #300

Merged
merged 2 commits into from
Sep 5, 2018

Conversation

nedcampion
Copy link
Contributor

@nedcampion nedcampion commented Jul 25, 2018

This is an initial take on adding support for newly added dynamic templates.

I've added an add_dynamic_tempalte_data method to the Personalization class as well as a test and some example code to show how it would be used.

Fixes #300

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jul 25, 2018
@SendGridDX
Copy link

SendGridDX commented Jul 25, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

This is awesome @nedcampion!

Are you having an issue with our CLA? Is should be pretty quick and simple to get that signed, just need to click here and fill out a short form.

Thanks!

With Best Regards,

Elmer

@nedcampion
Copy link
Contributor Author

nedcampion commented Jul 25, 2018

I think I got it signed properly, but let me know if I missed something @thinkingserious. Also, I think this is going to fail the test suite (as the last PR did) because of three other tests that are failing.

@thinkingserious
Copy link
Contributor

You got it @nedcampion! I'll get the other tests squared away :)

@acflint
Copy link

acflint commented Aug 3, 2018

Oh damn, I guess I should have checked here first. I just made a pull request for the same thing. Good on you, @nedcampion!

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty labels Aug 4, 2018
@lucaswhitman
Copy link

Any chance this one is coming in soon? I'm very excited... 😁

@thinkingserious
Copy link
Contributor

Hello @lucaswhitman,

I'm currently in the process of adding dynamic template support for all of our libraries, including Ruby. My apologies for the delay and unfortunately I don't have a solid ETA just yet.

With Best Regards,

Elmer

@lucaswhitman
Copy link

@thinkingserious no worries, I'm pulling together a work around for now, just thought I'd check before committing to it. Thanks for the update!

@metaskills
Copy link

I'm currently in the process of adding dynamic template support for all of our libraries, including Ruby.

FWIW, I am doing this now with the current client with the method client.mail._('send').post(request_body: data) where data is as described in this article (https://sendgrid.com/docs/User_Guide/Transactional_Templates/how_to_send_an_email_with_transactional_templates.html) but with one error.

In the article, the template_id should be at the root of the JSON object, not under personalizations.

@lucaswhitman
Copy link

@metaskills - thanks for the follow up! I'm walking down that road this morning and just sent my first successful test email.

@af4ro af4ro added the status: ready for deploy code ready to be released in next deploy label Aug 8, 2018
@thinkingserious thinkingserious removed the status: code review request requesting a community code review or review from Twilio label Aug 8, 2018
@thinkingserious thinkingserious merged commit a93d712 into sendgrid:master Sep 5, 2018
@thinkingserious
Copy link
Contributor

Hello @nedcampion,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@haffla
Copy link

haffla commented Sep 6, 2018

What's stopping this from being released?

Last release Oct 2017!

@thinkingserious
Copy link
Contributor

Hello @haffla,

We now just have Java and Go coming up next before this one. It should not be much longer.

With Best Regards,

Elmer

@Davidslv
Copy link

Can we have this released, please?

@thinkingserious
Copy link
Contributor

Hi @Davidslv,

Yes, this will be released soon. I'm close to releasing Java, then we will release Go and then I'll get this one out there.

My apologies for the delay and thank you for your patience.

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants